Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile friendly pdf redaction #889

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

bikubi
Copy link
Contributor

@bikubi bikubi commented Nov 11, 2024

At the moment this contains pdfupload-fixes; I will rebase as soon as that lands.

note the tool toggle on the left and the zoom ui:

grafik

last minute TODO: the tooltip I've added to the tool toggles doesn't respect data-bs-placement (I don't know why), so I might just disable the tooltip on mobile, where it can block the other button, and is generally in the way.

  • placement does work, it just flips to right for the long titles
  • I've implemented a way to auto-hide the tooltips after a timeout (set to 3s), after focusin events - this won't affect mouse users, but mobile touchers and (unfortunately) keyboard users. A cleaner fix would send adequate events from panzoom to focusout the tooltips...

@bikubi bikubi requested review from pajowu and krmax44 November 11, 2024 17:15
@bikubi bikubi force-pushed the bikubi/pdfredaction-mobile2 branch 3 times, most recently from 889bb05 to 63786de Compare November 21, 2024 19:25
@bikubi
Copy link
Contributor Author

bikubi commented Nov 21, 2024

@pajowu @krmax44
toolbars are now sticky, i moved the two main tools there, moved pagination to the bottom toolbar, which relaxed everything. i've removed the tooltips, they didn't make sense (as a replacement for button labels on mobile), instead i've updated the how-to above, directly&visually referring to the buttons by label or icon, resp.

@krmax44
Copy link
Member

krmax44 commented Nov 26, 2024

On desktop, the redaction view is kind of small when uploading postal messages. Maybe we can shrink the help text a little? The moving tool has a (wrong) label on desktop. In the postal upload's redaction view, the page navigation and switch between text only/image view is invisible.

I'm unsure about the tool selector floating above the document. Maybe back to the toolbar? The line breaks labels in the toolbar could be removed to save space.

image

On mobile, it's also small when redacting landscape documents. Perhaps the redaction view should at minimum always fill the screen height?

image

I think we could remove the container around the redaction tool, to give it full screen width.

The shift shortcut to switch between moving and redacting has the unfortunate side effect that shift + drag sometimes moves and sometimes redacts, seemingly at random.

@krmax44
Copy link
Member

krmax44 commented Nov 26, 2024

Also, the help texts for redaction differ between the "standalone" redaction and when you're redacting during post upload. We should probably use the same on both. Maybe with the option to collapse them, so experienced users don't have to scroll as much.

@bikubi bikubi force-pushed the bikubi/pdfredaction-mobile2 branch from 63786de to 485228e Compare November 27, 2024 09:05
@bikubi bikubi force-pushed the bikubi/pdfredaction-mobile2 branch from 485228e to 2c9e000 Compare November 28, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants