-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile friendly pdf redaction #889
base: main
Are you sure you want to change the base?
Conversation
889bb05
to
63786de
Compare
@pajowu @krmax44 |
On desktop, the redaction view is kind of small when uploading postal messages. Maybe we can shrink the help text a little? The moving tool has a (wrong) label on desktop. In the postal upload's redaction view, the page navigation and switch between text only/image view is invisible. I'm unsure about the tool selector floating above the document. Maybe back to the toolbar? The line breaks labels in the toolbar could be removed to save space. On mobile, it's also small when redacting landscape documents. Perhaps the redaction view should at minimum always fill the screen height? I think we could remove the container around the redaction tool, to give it full screen width. The shift shortcut to switch between moving and redacting has the unfortunate side effect that shift + drag sometimes moves and sometimes redacts, seemingly at random. |
Also, the help texts for redaction differ between the "standalone" redaction and when you're redacting during post upload. We should probably use the same on both. Maybe with the option to collapse them, so experienced users don't have to scroll as much. |
63786de
to
485228e
Compare
including - PDF rendering at higher dpi - vBsTooltip vs Options API - text mode redaction
plus i18n cleanup
reverts a lot of 325eec2
to 100vh-ish
which has also a sticky top toolbar
documentation for vBsTooltip directive
485228e
to
2c9e000
Compare
At the moment this contains pdfupload-fixes; I will rebase as soon as that lands.
responsive sizes only via workaround
⇒ abandoned, because code was behaving weirdly
note the tool toggle on the left and the zoom ui:
last minute TODO: the tooltip I've added to the tool toggles doesn't respectdata-bs-placement
(I don't know why), so I might just disable the tooltip on mobile, where it can block the other button, and is generally in the way.placement
does work, it just flips toright
for the longtitle
sfocusin
events - this won't affect mouse users, but mobile touchers and (unfortunately) keyboard users. A cleaner fix would send adequate events from panzoom tofocusout
the tooltips...