Added pretix newsletter CSV import #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanw
reviewed
Sep 17, 2024
pajowu
requested changes
Oct 23, 2024
| } | ||
| elif "first_name" in headers and "last_name" in headers: | ||
| csv_format = { | ||
| "name": "combine", |
There was a problem hiding this comment.
Not a fan of storing different things in name: both a column name and a magic constant which implies that two columns should be combined. I suggest to instead return a list of fields here and checking in import_csv whether a list was returned (isinstance(row['name'], list))
There was a problem hiding this comment.
To simplify this could also always return a list for name, which for the other cases only contains a single entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.