Nova Scotia Basic Personal Amount

Fixes PolicyEngine#395
okeyiii · Jul 31, 2023 · f13d546 · f13d546
1 parent cafa9ed
commit f13d546
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 13 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -1,5 +1,5 @@
-- bump: minor
+- bump: patch
   changes:
     added:
-    - Nova Scotia Basic personal amount.
+    - Chage names to proper expressions for title, label, reference and folder.
 
diff --git a/...eters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml b/...eters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
@@ -5,7 +5,7 @@ metadata:
   unit: currency-CAD
   label: Nova Scotia Additional Personal Amount
   reference: 
-  - title: Nova Scotia Basic Personal Amount
+  - title: 2022 Nova Scotia Personal Tax Credits Return
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
-  - title: Nova Scotia Basic Personal Amount
+  - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...ameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml b/...ameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
@@ -2,10 +2,12 @@ description: Nova Scotia employs this applicable rate for calculating partial ba
 values: 
   2022-01-01: 0.06
 metadata:
-  unit: \1
+  unit: currency-CAD 
+  period: year 
+  rate_unit: /1
   label: Nova Scotia Basic Personal Amount Applicable Rate
   reference: 
-  - title: Nova Scotia Basic Personal Amount
+  - title: 2022 Nova Scotia Personal Tax Credits Return
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
-  - title: Nova Scotia Basic Personal Amount
+  - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml b/...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml
@@ -5,7 +5,7 @@ metadata:
   unit: currency-CAD
   label: Nova Scotia Basic Personal Amount
   reference: 
-  - title: Nova Scotia Basic Personal Amount
+  - title: 2022 Nova Scotia Personal Tax Credits Return
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
-  - title: Nova Scotia Basic Personal Amount
+  - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml b/...gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml
@@ -5,7 +5,7 @@ metadata:
   unit: currency-CAD
   label: Nova Scotia Basic Personal Amount Higher Income Threshold
   reference: 
-  - title: Nova Scotia Basic Personal Amount
+  - title: 2022 Nova Scotia Personal Tax Credits Return
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
-  - title: Nova Scotia Basic Personal Amount
+  - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/.../gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml b/.../gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml
@@ -5,7 +5,7 @@ metadata:
   unit: currency-CAD
   label: Nova Scotia Basic Personal Amount Lower Income Threshold
   reference: 
-  - title: Nova Scotia Basic Personal Amount
+  - title: 2022 Nova Scotia Personal Tax Credits Return
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
-  - title: Nova Scotia Basic Personal Amount
+  - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...come/credits/ns_basic_personal_credits.py → .../income/credits/basic_personal_credits.py b/...come/credits/ns_basic_personal_credits.py → .../income/credits/basic_personal_credits.py
@@ -7,6 +7,8 @@ class ns_basic_personal_credits(Variable):
     label = "Nova Scotia Basic Personal Amount"
     definition_period = YEAR
     defined_for = ProvinceCode.NS
+    reference = ("https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf", 
+                 "https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf")
 
     def formula(person, period, parameters):
         p = parameters(