Nova Scotia Basic Personal Amount

Fixes PolicyEngine#395
okeyiii · Aug 30, 2023 · 7bbcf3a · 7bbcf3a
1 parent 948dce7
commit 7bbcf3a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -1,5 +1,5 @@
 - bump: minor
  changes:
  added:
- - Nova Scotia Basic Personal Amount
+ - Nova Scotia Basic Personal Amount.
 
diff --git a/...v/provinces/ns/tax/income/credits/basic_personal_amount/additional_amount/max_amount.yaml b/...v/provinces/ns/tax/income/credits/basic_personal_amount/additional_amount/max_amount.yaml
@@ -1,17 +1,13 @@
 description: Nova Scotia phases its additional basic personal amount out at this rate.
 brackets:
  - threshold:
- values:
- 2022-01-01: 0
+ 2022-01-01: 0
  rate:
- values:
- 2022-01-01: 0
+ 2022-01-01: 0
  - threshold:
- values:
- 2022-01-01: 25_000
+ 2022-01-01: 25_000
  rate:
- values:
- 2022-01-01: 0.06
+ 2022-01-01: 0.06
 
 metadata:
  type: marginal_rate

diff --git a/...cyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py b/...cyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
@@ -21,13 +21,13 @@ def formula(person, period, parameters):
 
  # Calculate additional amount added to base amount
 
- reduced_additional_amount = (
+ reduced_additional_amount = max_(
+ 0,
  p.additional_amount.additional_amount
- - p.additional_amount.max_amount.calc(taxable_income)
+ - p.additional_amount.max_amount.calc(taxable_income),
  )
- additional_amount = max_(0, reduced_additional_amount)
  additional_amount = min_(
- additional_amount, p.additional_amount.additional_amount
+ reduced_additional_amount, p.additional_amount.additional_amount
  )
 
  return p.base + additional_amount