Nova Scotia Basic Personal Amount

Fixes PolicyEngine#395 add reference, try to slove version issue by git
okeyiii · Aug 10, 2023 · 02b51c5 · 02b51c5
1 parent a8f1e15
commit 02b51c5
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 7 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -1,5 +1,5 @@
 - bump: minor
   changes:
     added:
-    - Nova Scotia Basic Personal Amount.
+    - Nova Scotia Basic Personal Amount
 
diff --git a/...nces/ns/tax/income/credits/basic_personal_amount/additional_amount/additional_amount.yaml b/...nces/ns/tax/income/credits/basic_personal_amount/additional_amount/additional_amount.yaml
@@ -6,6 +6,9 @@ metadata:
   label: Nova Scotia basic personal amount additional amount
   reference: 
   - title: 2022 Nova Scotia Personal Tax Credits Return
-    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
+    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf#page=1
   - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+  - title: Nova Scotia income tax act
+    href: https://nslegislature.ca/sites/default/files/legc/statutes/income%20tax.pdf#page=24
+
diff --git a/...vinces/ns/tax/income/credits/basic_personal_amount/additional_amount/applicable_rate.yaml b/...vinces/ns/tax/income/credits/basic_personal_amount/additional_amount/applicable_rate.yaml
@@ -1,4 +1,4 @@
-description: Nova Scotia reduces its additional basic personal amount out at this rate.
+description: Nova Scotia phases its additional basic personal amount out at this rate.
 values: 
   2022-01-01: 0.06
 metadata:
@@ -9,6 +9,8 @@ metadata:
 
   reference: 
   - title: 2022 Nova Scotia Personal Tax Credits Return
-    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
+    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf#page=1
   - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+  - title: Nova Scotia income tax act
+    href: https://nslegislature.ca/sites/default/files/legc/statutes/income%20tax.pdf#page=24
diff --git a/...ns/tax/income/credits/basic_personal_amount/additional_amount/lower_income_threshold.yaml b/...ns/tax/income/credits/basic_personal_amount/additional_amount/lower_income_threshold.yaml
@@ -6,6 +6,8 @@ metadata:
   label: Nova Scotia basic personal amount additional amount phase out start
   reference: 
   - title: 2022 Nova Scotia Personal Tax Credits Return
-    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
+    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf#page=1
   - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+  - title: Nova Scotia income tax act
+    href: https://nslegislature.ca/sites/default/files/legc/statutes/income%20tax.pdf#page=24
diff --git a/...ine_canada/parameters/gov/provinces/ns/tax/income/credits/basic_personal_amount/base.yaml b/...ine_canada/parameters/gov/provinces/ns/tax/income/credits/basic_personal_amount/base.yaml
@@ -6,6 +6,8 @@ metadata:
   label: Nova Scotia basic personal amount base
   reference: 
   - title: 2022 Nova Scotia Personal Tax Credits Return
-    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
+    href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf#page=1
   - title: Worksheet NS428
     href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+  - title: Nova Scotia income tax act
+    href: https://nslegislature.ca/sites/default/files/legc/statutes/income%20tax.pdf#page=24
diff --git a/...cyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py b/...cyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
@@ -8,8 +8,9 @@ class ns_basic_personal_amount(Variable):
     definition_period = YEAR
     defined_for = ProvinceCode.NS
     reference = (
-        "https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf",
+        "https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf#page=1",
         "https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf",
+        "https://nslegislature.ca/sites/default/files/legc/statutes/income%20tax.pdf#page=24",
     )
 
     def formula(person, period, parameters):