Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix disabling plugins by accident in omz plugin disable #12401

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(cli): fix disabling plugins by accident in omz plugin disable #12401

merged 1 commit into from
May 8, 2024

Conversation

mcornella
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Adds word-boundary regexes in awk script to be more accurate in regex replace.

Fixes #12400

@ohmyzsh ohmyzsh bot added the Area: core Issue or PR related to core parts of the project label May 7, 2024
@mcornella mcornella mentioned this pull request May 7, 2024
Closed
@mcornella
fix(cli): fix edge cases in omz plugin disable command
d15481a 
Also introduces tests, which will be refactored into the proper
place when a test system is finally designed.

Fixes ohmyzsh#12400
@mcornella mcornella requested a review from carlosala May 8, 2024 18:57
carlosala
carlosala approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! awk always surprises me though haha, nice test suite! 🚀

@mcornella mcornella merged commit b0561d2 into ohmyzsh:master May 8, 2024
2 checks passed
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request May 11, 2024
@lesterchan
Merge remote-tracking branch 'upstream/master'
0514368 
* upstream/master: (58 commits)
  fix(git): add checked-out branch support to `gbg*` (ohmyzsh#12397)
  feat(procs): add completions plugin (ohmyzsh#12406)
  fix(nvm): use `command cat` to avoid alias (ohmyzsh#12410)
  fix(nvm): use `nvm version` when needed (ohmyzsh#12409)
  feat(dependencies): add `wd` (ohmyzsh#12405)
  fix(cli): fix edge cases in `omz plugin disable` command (ohmyzsh#12401)
  feat(nvm): add `corepack` to `lazy_cmd`
  feat(python): autovenv keeps activated on subdirs (ohmyzsh#12396)
  fix(extract): `zst` now extracts as expected (ohmyzsh#12395)
  feat(termsupport): support `alacritty*` TERM (ohmyzsh#12392)
  feat(autojump): add `nix-darwin` install path (ohmyzsh#12389)
  fix(fzf): support old `fzf` versions
  fix(copybuffer): prevent `which` alias usage (ohmyzsh#12379)
  fix(poetry-env): do not deactivate in a subdir
  feat(fishy): add color to username (ohmyzsh#12369)
  fix(ssh-agent): add identity only if identity exists (ohmyzsh#12371)
  chore(async): reenable async prompt by default on zsh < 5.0.6 (ohmyzsh#12358)
  fix(async): fix crash on zsh < 5.0.6 (ohmyzsh#12358)
  feat(fzf): support fzf setup for 0.48.0 and older (ohmyzsh#12367)
  fix(history): add `t` option to history wrapper (ohmyzsh#12365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: core Issue or PR related to core parts of the project
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

omz plugin disable breaks .zshrc file when disabling common substring
2 participants
@mcornella @carlosala