Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detecting Contour terminal in title() function #11599

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

christianparpart
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

Contour Terminal is is supporting OSC 1 and OSC 2 as well as host programmable statusline, which can be controlled via terminfo entries tsl / fsl / dsl. OMZ seems to use tsl/fsl to fallback-set the window title, and that is heavily confusing. So this change ensures OSC 1 + OSC 2 logic is used, to streamline this change with most TEs.

Other comments:

I personally think that the host programmable statusline is a bad start to simply show that string is probably not the best choice to begin with. Despired having rare support for it. :)

@ohmyzsh ohmyzsh bot added the Area: core Issue or PR related to core parts of the project label Apr 4, 2023
@carlosala
Copy link
Member

Thanks!

hron84 pushed a commit to hron84/oh-my-zsh that referenced this pull request Apr 11, 2023
kis87988 pushed a commit to kis87988/ohmyzsh that referenced this pull request May 21, 2023
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants