Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extract): always extract files into its own folder #11596

Merged
merged 2 commits into from
Apr 2, 2023
Merged

feat(extract): always extract files into its own folder #11596

merged 2 commits into from
Apr 2, 2023

Conversation

mcornella
Copy link
Member

@mcornella mcornella commented Apr 2, 2023 •
edited

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Creates a folder based on file name and extracts the contents from within this folder
  • Remove the folder if there was an error
  • If the only content in the extraction folder is one folder, move the folder up and remove the created extraction folder

Fixes #11537

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Apr 2, 2023
@mcornella mcornella mentioned this pull request Apr 2, 2023
Closed
carlosala
carlosala reviewed Apr 2, 2023
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! Just those two small things, really nice improvement Marc! 😊

plugins/extract/extract.plugin.zsh Outdated Show resolved Hide resolved
plugins/extract/extract.plugin.zsh Outdated Show resolved Hide resolved
carlosala
carlosala approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super fast fix! I learnt a new glob qualifier haha :)
LGTM😉

@mcornella mcornella merged commit 75405b7 into ohmyzsh:master Apr 2, 2023
fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Apr 2, 2023
@mcornella @fdelacruz
feat(extract): always extract files into its own folder (ohmyzsh#11596)
180e31b
@mcornella mcornella deleted the feat/extract-in-folder branch April 2, 2023 14:30
hron84 pushed a commit to hron84/oh-my-zsh that referenced this pull request Apr 11, 2023
@mcornella @hron84
feat(extract): always extract files into its own folder (ohmyzsh#11596)
16d5f5b
@hwalinga hwalinga mentioned this pull request Apr 25, 2023
Closed
kis87988 pushed a commit to kis87988/ohmyzsh that referenced this pull request May 21, 2023
@mcornella @kis87988
feat(extract): always extract files into its own folder (ohmyzsh#11596)
b90c7b8
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
@mcornella @nbaronov
feat(extract): always extract files into its own folder (ohmyzsh#11596)
7bde256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extract Plugin: Can automatically create the decompression directory
2 participants
@mcornella @carlosala