Try3 - Cache FDB #46
Open
Try3 - Cache FDB #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. |
ohhmm
reviewed
Aug 8, 2022
| @@ -28,18 +30,18 @@ if(NOT WIN32) | |||
| set(DEPENDENCIES ${DEPENDENCIES} boost_thread boost_serialization boost_system) | |||
| endif() | |||
|
|
|||
| lib(${DEPENDENCIES}) | |||
There was a problem hiding this comment.
this lib function declares new library project with dependencies enumerated in params (${DEPENDENCIES})
ohhmm
reviewed
Aug 8, 2022
| template < typename pageCache> | ||
|
|
||
| class Reference : public EvictablePageCache ::future<pageCache> { | ||
| using base = std::future<pageCache>;//creo que lo de abajo es lo mismo |
|
I'll extract caching functionality into new sibling sublibrary 'storage'. |
|
Integrating storage component to simplify this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.