Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case if we set a timestamp field default to current time #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmcomp
Copy link

@mmcomp mmcomp commented Nov 8, 2022

No description provided.

@oguimbal
Copy link
Owner

oguimbal commented Nov 8, 2022

Hi, thanks for this PR !

That said, the diff is too complicated, I cant see what has changed.

Would it possible to re-push this, only with actual changes ?

  1. I use single quotes for strings
  2. Please don't reorder properties
  3. I dont wrap single argument lambdas with parenthesis
  4. You've changed identation

@oguimbal
Copy link
Owner

oguimbal commented Nov 9, 2022

ah, and it would be nice to have a unit test that demonstrate what you are trying to solve (and prevent regressions in the future 😉)

@abenhamdine
Copy link

Looks like the actual change is limited to these 2 lines :

image

@mmcomp perhaps you can submit only this change and a unit test ?

@Thore1954
Copy link

Nice eye @abenhamdine, but I don't understand the point of it anyway.
If they mean something like "myColumn" timestamp default now() then it already works.

@abenhamdine
Copy link

Nice eye @abenhamdine, but I don't understand the point of it anyway.
If they mean something like "myColumn" timestamp default now() then it already works

Actually I don't know if this change is needed, I was just asking for adding a test.
If this change is controversial, then a first PR should demonstrate the bug by adding a failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants