Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved mikro-orm to devDependencies #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

L2jLiga
Copy link

@L2jLiga L2jLiga commented Sep 22, 2022

Closes #255

@Thore1954
Copy link

It should also be added in peerDependencies.

@L2jLiga
Copy link
Author

L2jLiga commented Dec 4, 2022

This will break the install for those using npm v7 with mikro-orm v5

https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies

@Thore1954
Copy link

That's why the version should be specified as the range >=4.5.3.

@L2jLiga
Copy link
Author

L2jLiga commented Dec 5, 2022

That's why the version should be specified as the range >=4.5.3.

Thanks for suggestion, just added them

knixeur added a commit to knixeur/pg-mem that referenced this pull request Aug 16, 2023
knixeur added a commit to knixeur/pg-mem that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MikroORM as a dependency
2 participants