Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small simp of fauzi's recent futility commit #5924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ergodice
Copy link
Contributor

@Ergodice Ergodice commented Mar 8, 2025

Simplify condition in futility pruning

Passed STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 427040 W: 111061 L: 111271 D: 204708
Ptnml(0-2): 1709, 48524, 113171, 48500, 1616
https://tests.stockfishchess.org/tests/view/67af01d01a4c73ae1f930ea4

Passed rebased LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 28704 W: 7330 L: 7120 D: 14254
Ptnml(0-2): 8, 3000, 8138, 3186, 20
https://tests.stockfishchess.org/tests/view/67ca629a45214989aa0a123e

bench 1823605

Copy link

github-actions bot commented Mar 8, 2025

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 13742375216 / attempt 1)

@FauziAkram
Copy link
Contributor

FauziAkram commented Mar 9, 2025

Just a quick note that might be useful for other devs/maintainers.

Since the LTC test bench remained unchanged (unlike the STC test), I ran a debug to investigate why.

master...FauziAkram:Stockfish:ewf4343f34

However, as shown below:
Hit #0: Total 266108 Hits 256813 Hit Rate (%) 96.5071
Mean #0: Total 266108 Mean -0.605431
Extremity #0: Total 266108 Min -10 Max 32

The hit rate of the removed condition isn’t 100%, and lmrdepth exceeds 7, which makes it extra strange that bench is unvaried.

@Disservin Disservin added the simplification A simplification patch label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification A simplification patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants