[IMP] fields: use ignored field for respawn #209
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Xavier-Do
force-pushed
the
master-ignore-respawn-xdo
branch
2 times, most recently
from
efafb6f to
04e94c1
Compare
When a field reappears after an upgrade, a log with the format "field ... has respawn!" is emited. In some case, it is possible that this error should be silenced. The current case was because an upgrade script targeting 18.2 was merged during the freeze and should target 18.3. During a short time frame after a freeze, some branch may be tested without testing the upgrade from the freshly created branch since no template are available. In this case, a script was merged with an invalid version number. A pull request (#7240) was created to fix it but it took some time to be merged and then to be used by latest builds. An exeption was added in master, fixing the 18.2-> master but this exception was not working for the 18.*->18.2 error. This commit will use the same exception to silence this error allowing quick fixes in this kind of situation.
Xavier-Do
force-pushed
the
master-ignore-respawn-xdo
branch
from
04e94c1 to
4f177c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a field reappears after an upgrade, a log with the format "field ... has respawn!" is emited. In some case, it is possible that this error should be silenced.
The current case was because an upgrade script targeting 18.2 was merged during the freeze and should target 18.3. During a short time frame after a freeze, some branch may be tested without testing the upgrade from the freshly created branch since no template are available.
In this case, a script was merged with an invalid version number. A pull request (#7240) was created to fix it but it took some time to be merged and then to be used by latest builds.
An exeption was added in master, fixing the 18.2-> master but this exception was not working for the 18.*->18.2 error. This commit will use the same exception to silence this error allowing quick fixes in this kind of situation.