Skip to content

[IMP] runbot: show cached ADD line in a comment #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xavier-Do wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[IMP] runbot: show cached ADD line in a comment #1357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runbot/models/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def _get_cached_content(self, docker_build_path):
destination = add_match.group('destination')
# Use the destination name as hardlink name to avoid rebuild if file content is the same but not the url
hardlink_name = re.sub(r'[^a-zA-Z0-9]', '_', destination)
lines[i + 1] = f'COPY {hardlink_name} {destination}'
lines[i + 1] = f'# CACHED {line}\nCOPY {hardlink_name} {destination}\n'
cache_file_path = cache_dir / filename
if not cache_file_path.exists() or time.time() - cache_file_path.lstat().st_mtime > cache_duration:
try:
Expand Down