[FIX] selection input: highlight color not sync with range color #5734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
force-pushed
the
master-fix-selection-input-reorder-colors-adrm
branch
from
c683699 to
99fa619
Compare
After re-ordering the selection inputs of a chart, the highlight colors would not be the same as the range colors. This was because the store mutator `updateColors` would not update the store range colors. And `store.highlights` is based on `ranges.colors` while `store.selectionInputs` ignores the colors of `store.ranges`. The test `update of colors are taken into account` was also a bit sketchy. We would modify the `props.colors` array in place, thus the condition `nextProps.colors !== props.colors` would never be satisfied, and `store.updateColors` would never be called. Task: 4577803
rrahir
force-pushed
the
master-fix-selection-input-reorder-colors-adrm
branch
from
99fa619 to
692eb20
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 27, 2025
After re-ordering the selection inputs of a chart, the highlight colors would not be the same as the range colors. This was because the store mutator `updateColors` would not update the store range colors. And `store.highlights` is based on `ranges.colors` while `store.selectionInputs` ignores the colors of `store.ranges`. The test `update of colors are taken into account` was also a bit sketchy. We would modify the `props.colors` array in place, thus the condition `nextProps.colors !== props.colors` would never be satisfied, and `store.updateColors` would never be called. closes #5734 Task: 4577803 Signed-off-by: Rémi Rahir (rar) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After re-ordering the selection inputs of a chart, the highlight colors would not be the same as the range colors.
This was because the store mutator
updateColorswould not update the store range colors. Andstore.highlightsis based onranges.colorswhilestore.selectionInputsignores the colors ofstore.ranges.The test
update of colors are taken into accountwas also a bit sketchy. We would modify theprops.colorsarray in place, thus the conditionnextProps.colors !== props.colorswould never be satisfied, andstore.updateColorswould never be called.Task: 4577803
review checklist