[FIX] selection input: highlight color not sync with range color #5734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After re-ordering the selection inputs of a chart, the highlight colors would not be the same as the range colors.
This was because the store mutator
updateColors
would not update the store range colors. Andstore.highlights
is based onranges.colors
whilestore.selectionInputs
ignores the colors ofstore.ranges
.The test
update of colors are taken into account
was also a bit sketchy. We would modify theprops.colors
array in place, thus the conditionnextProps.colors !== props.colors
would never be satisfied, andstore.updateColors
would never be called.Task: 4577803
review checklist