[FIX] clipboard: paste multiline text from OS clipboard #5705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The implementation of the paste from OS clipboard a simple split on `\n` and `\t` to get the rows and columns in the clipboard. This obviously doesn't work if the cells copied from Excel contain newlines or tabs. This commit fixes it by parsing the HTML content of the clipboard instead of the plain text. This makes it clear what the separation of row/cols are in the clipboard. Task: 4570998
hokolomopo
force-pushed
the
18.0-multiline-os-clipboard-adrm
branch
from
f26d91b to
35592a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation of the paste from OS clipboard a simple split on
\nand\tto get the rows and columns in the clipboard. This obviously doesn't work if the cells copied from Excel contain newlines or tabs.This commit fixes it by parsing the HTML content of the clipboard instead of the plain text. This makes it clear what the separation of row/cols are in the clipboard.
Task: 4570998
review checklist