[FIX] test_generic: improve test using ast instead of regex#1926
Open
fw-bot wants to merge 1 commit intoodoo:saas-19.1from
Open
[FIX] test_generic: improve test using ast instead of regex#1926fw-bot wants to merge 1 commit intoodoo:saas-19.1from
fw-bot wants to merge 1 commit intoodoo:saas-19.1from
Conversation
There is a test ensuring that there is no use of `search([...]).id` without adding a `limit=1` (or using .ids). This test was relying on a complicated regex. This commit improves the test by relying on `ast` and corrects remaining occurrences that were not raised by previous version of the test. X-original-commit: b9832f6
Collaborator
|
|
Author
|
This PR targets saas-19.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a test ensuring that there is no use of
search([...]).idwithout adding a
limit=1(or using .ids). This test was relying on acomplicated regex. This commit improves the test by relying on
astandcorrects remaining occurrences that were not raised by previous version
of the test.
opw-6037120
Forward-Port-Of: #1919
Forward-Port-Of: #1894