[IMP] construction_developer: versatile work items pricing#1916
Open
fw-bot wants to merge 2 commits intoodoo:saas-19.2from
Open
[IMP] construction_developer: versatile work items pricing#1916fw-bot wants to merge 2 commits intoodoo:saas-19.2from
fw-bot wants to merge 2 commits intoodoo:saas-19.2from
Conversation
Collaborator
|
|
Author
|
@frva-odoo @vava-odoo cherrypicking of pull request #1855 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Improves the work item model with the possibility to manage prices manually. Before this commit, every work item had their cost and price defined as the sum of their components costs and prices. Now, this works as before but we can check the fixed checkbox next to the margin to enable an alternative behavior: Input manually a fixed margin or a fixed price. This margin is kept and impacts the price when the cost of components changes. Task-5262058 X-original-commit: ed32528 Part-of: odoo#1915 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
vava-odoo
force-pushed
the
saas-19.2-19.0-versatile-work-item-pricing-frva-512557-fw
branch
from
a1448b0 to
587c4b5
Compare
This commit adds tests for some behavior defined by server action; - Test the creation of a work item related to a sale order, see if the product is created behind. - Test that there is a single work item template at the same time for a product - Test the cost, price and margin of a work item whenever components changes or work item values are changed directly closes odoo#1915 X-original-commit: 5a81567 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
vava-odoo
force-pushed
the
saas-19.2-19.0-versatile-work-item-pricing-frva-512557-fw
branch
from
587c4b5 to
5c9cb3a
Compare
Collaborator
|
@robodoo r+ |
Collaborator
|
@frva-odoo @vava-odoo 'ci/industry' failed on this reviewed PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the work item model with the possibility to manage prices manually.
Before this PR, every work item had their cost and price defined as the sum of their components costs and prices.
Now, this works as before but we can check the fixed checkbox next to the margin to enable an alternative behavior:
Input manually a fixed margin or a fixed price. This margin is kept and impacts the price when the cost of components changes.
A second commit in this pr adds some tests for the construction module:
Task-5262058
Forward-Port-Of: #1855