[FIX] tests: don't confuse separators for heading delimiters #12111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AntoineVDV
commented
Feb 19, 2025
Feyensv
approved these changes
Mar 4, 2025
RST separators (`-----`) look similar to H3 delimiters that use the same `-` character, but separators' length should not be checked.
This commit fixes a bug in the `check_early_line_breaks` test that would systematically consider the `\n` character as being part of the line, hence counting it when computing the line length.
AntoineVDV
force-pushed
the
16.0-fix-tests-delimiter-anv
branch
from
590e70b to
de10e72
Compare
|
@robodoo r+ rebase-ff FYI @samueljlieber |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 5, 2025
RST separators (`-----`) look similar to H3 delimiters that use the same `-` character, but separators' length should not be checked. Part-of: #12111 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Mar 5, 2025
This commit fixes a bug in the `check_early_line_breaks` test that would systematically consider the `\n` character as being part of the line, hence counting it when computing the line length. closes #12111 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] tests: don't confuse separators for heading delimiters
RST separators (
-----) look similar to H3 delimiters that use the same-character, but separators' length should not be checked.[FIX] tests: don't count EOL chars when checking remaining line space
This commit fixes a bug in the
check_early_line_breakstest that would systematically consider the\ncharacter as being part of the line, hence counting it when computing the line length.