-
Notifications
You must be signed in to change notification settings - Fork 117
Master mass mailing egg fix builder thjo #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thjo-odoo
wants to merge
13
commits into
master-mysterious-egG-mail
Choose a base branch
from
master-mass_mailing_egg-fix_builder-thjo
base: master-mysterious-egG-mail
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master mass mailing egg fix builder thjo #4794
thjo-odoo
wants to merge
13
commits into
master-mysterious-egG-mail
from
master-mass_mailing_egg-fix_builder-thjo
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egG-mail, it needs to be retargeted before it can be merged. |
8406f7b
to
432490b
Compare
This commit moves all the website_builder plugins that will be necessary for the mass_mailing conversion to the html_builder module. This lessens the load of what we would need to adapt for it. This move is also done ensuring that the current website_builder is still operational. task-4247642
…ervice In order to be able to use the `snippet_service` for `mass_mailing`, it can not depends on `website`. This commit removes that dependency and adjust impacted files. It is now possible to use different `snippetName` depending on the desired snippets bundle. task-4247642
This commit is only useful for the transition as we might encouter issues while testing => customize tab that no longer works.
This file needs to be updated each time that a snippet is handled
43c8bf4
to
edf4e37
Compare
edf4e37
to
1e8ecca
Compare
8e328ae
to
66633ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to the builder in mass_mailing_egg. Still needs the styling to be fixed.