fix infinite loop #4494
Open
fix infinite loop #4494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a race condition in the `onEditPage` method of the `WebsiteBuilder` component. The issue occurred when asynchronous operations (like iframe loading and asset bundle loading) were not completed before proceeding with the editing flow, leading to unpredictable behavior. Changes: - Added `await this.iframeLoaded` in `onEditPage` to ensure the iframe is fully loaded before loading assets or enabling editing. - Set the `is-ready` attribute on the iframe element in `onIframeLoad` to mark it as ready once the iframe content is loaded. These changes ensure that all dependencies are properly initialized before enabling the editing mode, resolving the race condition.
Now handling the Google Maps API in the iframe with an interaction, we can't test it anymore since the tests don't have access to the iframe and can't make overrides there, and therefore doesn't load the interaction.
When calling twice `customizeWebsiteColors` or `customizeWebsiteVariables` without awaiting them, the same file may be created twice in DB. This causes crashes (error 500 in both the backend and the frontend) which are very hard to recover from. This can happen due to the introduction of a `composite` action in the next commit, by going through clean/apply (for websiteConfig) or by calling 2 actions which both trigger one of the async methods. Additionnally, it's better to batch `reloadBundles` too so that its RPC call is only done once, at the end.
Before this commit, in website builder:
- overlay does not close when clicked outside the iframe (Toolbar, link popover)
- When you add a link with the link popover, it closes when you add the first char of the url.
- when you have a banner and text:
- you select the text
- the toolbar opens
- click on the banner icon
- The toolbar should close
when header template is changed, like old data-trigger
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
e24556e to
897f4ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.