[FIX] html_editor: linkpopover not opening #4490
Draft
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
msh-odoo
reviewed
Apr 28, 2025
| @@ -631,7 +631,7 @@ export class LinkPlugin extends Plugin { | |||
| } | |||
| } else { | |||
| const closestLinkElement = closestElement(selection.anchorNode, "A"); | |||
| if (closestLinkElement && closestLinkElement.isContentEditable) { | |||
| if (closestLinkElement) { | |||
There was a problem hiding this comment.
@visp-odoo I don't think removing isContentEditable condition is right solution, in case of Navbar links we have to handle the case, this issue will occur on links where anchor have span some other editable element, so I guess we need should check whether closestAnchor have editable child then we should allow further.
Previously Navbar links were explicitly handled.
visp-odoo
force-pushed
the
master-mysterious-egg-navbar-linkpopover-visp
branch
3 times, most recently
from
74e111c to
25dccc6
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
e24556e to
897f4ab
Compare
visp-odoo
force-pushed
the
master-mysterious-egg-navbar-linkpopover-visp
branch
from
25dccc6 to
029f43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linkpopover is not opening because the
o_editableandcontentEditable=Trueare applied to a span element inside an a tag.