Add interactive previews to snippets #4482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
ged-odoo
reviewed
Apr 24, 2025
| this.websiteEditService = this.websiteService.websiteRootInstance.bindService("website_edit"); | ||
|
|
||
| const updatePreview = () => { | ||
| const iframeDocument = document.querySelector("iframe.o_add_snippet_iframe").contentDocument; |
There was a problem hiding this comment.
it would be better to use a ref to directly access the target instead of doing this, in my opinion
ged-odoo
reviewed
Apr 24, 2025
| <t t-name="html_builder.SnippetViewer"> | ||
| <div class="row g-0 o_snippets_preview_row"> | ||
| <div class="col-lg-6" t-foreach="this.getSnippetColumns()" t-as="snippetsColumn" t-key="snippetsColumn_index"> | ||
| <t t-foreach="snippetsColumn" t-as="snippet" t-key="snippet.id"> |
There was a problem hiding this comment.
you can add a t-ref="content" on the root div from this template (the one with o_snippets_preview_row)
ged-odoo
reviewed
Apr 24, 2025
|
|
||
| setup() { | ||
| this.dialog = useService("dialog"); | ||
|
|
ged-odoo
reviewed
Apr 24, 2025
| this.dialog = useService("dialog"); | ||
|
|
||
| this.websiteService = useService("website"); | ||
| this.websiteEditService = this.websiteService.websiteRootInstance.bindService("website_edit"); |
There was a problem hiding this comment.
to avoid confusion, you should rename it this.innerWebsiteEditService maybe.
Syozik
force-pushed
the
master-mysterious-egg-seru-01
branch
7 times, most recently
from
e5e4ed1 to
211fec6
Compare
ged-odoo
reviewed
Apr 25, 2025
There was a problem hiding this comment.
if root is created in onMounted, it should probably be destroyed in onWillUnmount
Syozik
force-pushed
the
master-mysterious-egg-seru-01
branch
5 times, most recently
from
4f9d883 to
174fe6e
Compare
Syozik
force-pushed
the
master-mysterious-egg-seru-01
branch
from
174fe6e to
ddc5f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.