Updating test setup

oddbit · Feb 15, 2024 · 76c05c7 · 76c05c7
1 parent 88e038f
commit 76c05c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.github/workflows/build-deploy.yml b/.github/workflows/build-deploy.yml
@@ -19,6 +19,9 @@ jobs:
           - unit
           - e2e
     timeout-minutes: 30
+    env:
+      WEBHOOK_URL_GOOGLE_CHAT: ${{ secrets.WEBHOOK_URL_GOOGLE_CHAT }}
+      WEBHOOK_URL_SLACK: ${{ secrets.WEBHOOK_URL_SLACK }}
     steps:
       - uses: actions/checkout@v3
         name: Checkout code
@@ -48,11 +51,6 @@ jobs:
           key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
           restore-keys: ${{ runner.os }}-yarn-
 
-      - name: Replace Webhook URLs in Test File
-        run: |
-          sed -i '' 's|WEBHOOK_URL_GOOGLE_CHAT|'"${{ secrets.WEBHOOK_URL_GOOGLE_CHAT }}"'|g' functions/test/e2e/chat.spec.ts
-          sed -i '' 's|WEBHOOK_URL_SLACK|'"${{ secrets.WEBHOOK_URL_SLACK }}"'|g' functions/test/e2e/chat.spec.ts
-
       - run: yarn --cwd functions install
 
       - run: yarn --cwd functions build

diff --git a/functions/test/e2e/chat.spec.ts b/functions/test/e2e/chat.spec.ts
@@ -9,8 +9,8 @@ import { ApiService } from '../../src/services/chat.service';
 
 describe('End to end tests', () => {
   const webhooks: {[key: string]: string} = {
-    ['Google Chat']: 'WEBHOOK_URL_GOOGLE_CHAT',
-    ['Slack']: 'WEBHOOK_URL_SLACK',
+    ['Google Chat']: process.env.WEBHOOK_URL_GOOGLE_CHAT ?? 'WEBHOOK_URL_GOOGLE_CHAT_NOT_SET',
+    ['Slack']: process.env.WEBHOOK_URL_SLACK ?? 'WEBHOOK_URL_SLACK_NOT_SET',
   };
 
   before(() => {