-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock mechanism for scratch_dir creation, small refactoring #713
Conversation
…e the scratch dir
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
==========================================
+ Coverage 61.90% 61.98% +0.07%
==========================================
Files 50 50
Lines 9096 9114 +18
==========================================
+ Hits 5631 5649 +18
Misses 3465 3465 ☔ View full report in Codecov by Sentry. |
This approach has the downside of creating several empty lock files. After discussing with @dsavchenko about it, we agreed on extending the |
Use a lock and loop to attempt to acquire the lock to check and create the scratch dir, also with a small refactoring