Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock mechanism for scratch_dir creation, small refactoring #713

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

burnout87
Copy link
Collaborator

@burnout87 burnout87 commented Oct 7, 2024

Use a lock and loop to attempt to acquire the lock to check and create the scratch dir, also with a small refactoring

@burnout87 burnout87 changed the title use a lock and loop to attempt to acquire the lock to check and creat… Lock mechanism for scratch_dir creation Oct 7, 2024
@burnout87 burnout87 changed the title Lock mechanism for scratch_dir creation Lock mechanism for scratch_dir creation, small refactoring Oct 7, 2024
@burnout87 burnout87 self-assigned this Oct 7, 2024
@burnout87 burnout87 linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.98%. Comparing base (2d00c76) to head (4919457).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
cdci_data_analysis/flask_app/dispatcher_query.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   61.90%   61.98%   +0.07%     
==========================================
  Files          50       50              
  Lines        9096     9114      +18     
==========================================
+ Hits         5631     5649      +18     
  Misses       3465     3465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_server_basic.py Fixed Show fixed Hide fixed
@burnout87 burnout87 marked this pull request as ready for review October 7, 2024 13:13
@burnout87
Copy link
Collaborator Author

This approach has the downside of creating several empty lock files. After discussing with @dsavchenko about it, we agreed on extending the free-up-space to use the same logic to delete the lock files

@burnout87 burnout87 merged commit 1b0c79e into master Oct 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live tests generate identical non-aliased job ids
3 participants