-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly handling post request and sanitize request values before logging #705
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
- Coverage 62.36% 62.33% -0.03%
==========================================
Files 50 50
Lines 8957 8982 +25
==========================================
+ Hits 5586 5599 +13
- Misses 3371 3383 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, this should be straightforward, except for this log sanitization advice form QL.
…spatcher-app into reading-post-requests-gallery
defined a function that sanitizes the values of the request before logging, applied also to the what do you think? |
it turns out, the gallery-related endpoints are all only
POST
endpoint for the presence of files, so, adaptation is minimalalongside with oda-hub/oda_api#273