-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adql query parser function #696
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 62.05% 61.68% -0.38%
==========================================
Files 50 51 +1
Lines 9138 9237 +99
==========================================
+ Hits 5671 5698 +27
- Misses 3467 3539 +72 ☔ View full report in Codecov by Sentry. |
I did quite some progress on this PR in the last two days. Few important first points:
Why
|
I cant really understand this error : https://github.com/oda-hub/dispatcher-app/actions/runs/11054770284/job/30712623502?pr=696 Any ideas? It should not be related to this PR |
caused by a conflict between the |
@@ -708,10 +729,16 @@ | |||
yield yaml.load(open(dispatcher_test_conf_with_gallery_fn), Loader=yaml.SafeLoader)['dispatcher'] | |||
|
|||
|
|||
@pytest.fixture | |||
def dispatcher_test_conf_with_vo_options(dispatcher_test_conf_with_vo_options_fn): | |||
yield yaml.load(open(dispatcher_test_conf_with_vo_options_fn), Loader=yaml.SafeLoader)['dispatcher'] |
Check warning
Code scanning / CodeQL
File is not always closed Warning
Having tried to directly import the whole product gallery production DB, into the PostgreSQL (trying to create a PostgreSQL table out of the MySQL view, ie materializing) instance, resulted in the whole process to take an unsustainable amount of time, probably causing disruptions. So I decided to try and skip the materialization step. With that, the import was very quick (less than a minute), and after some initial testing, I realized that querying the view was still an option as the time taken was acceptable. |
No description provided.