Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service registry endpoints #50

Merged
merged 45 commits into from
Jul 5, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jun 29, 2023

Contents (#50)

New features

  • Add endpoint for getting/registering service revisions

Operations

  • Use octue/check-semantic-version action
  • Use latest pull request description action
  • Use latest Codecov action
  • Fix default argument in workflow

Dependencies

  • Add icecream to dev dependencies

Testing

  • Make test package structure mirror package structure
  • Test that only one revision of a service can be the default

Style

  • Fix pre-commit checks
  • Improve import spacing

@cortadocodes cortadocodes self-assigned this Jun 29, 2023
@cortadocodes cortadocodes linked an issue Jun 29, 2023 that may be closed by this pull request
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #50 (b0aa3bd) into main (a426e55) will increase coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   49.19%   51.30%   +2.10%     
==========================================
  Files          41       44       +3     
  Lines         811      842      +31     
==========================================
+ Hits          399      432      +33     
+ Misses        412      410       -2     
Impacted Files Coverage Δ
django_twined/consumers/analysis.py 0.00% <ø> (ø)
django_twined/consumers/analysis_log.py 0.00% <ø> (ø)
django_twined/consumers/service.py 0.00% <ø> (ø)
django_twined/fields.py 88.23% <ø> (ø)
...ngo_twined/management/commands/sync_data_stores.py 0.00% <ø> (ø)
django_twined/messages.py 0.00% <ø> (ø)
django_twined/migrations/0001_initial.py 100.00% <ø> (ø)
...ed/migrations/0006_service_revisions_and_events.py 100.00% <ø> (ø)
django_twined/models/datastores.py 42.57% <ø> (ø)
...ango_twined/models/querysets/datastore_queryset.py 20.21% <ø> (ø)
... and 8 more

Copy link
Contributor

@thclark thclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of suggestions made!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
django_twined/views.py Show resolved Hide resolved
django_twined/views.py Outdated Show resolved Hide resolved
django_twined/views.py Outdated Show resolved Hide resolved
django_twined/views.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/server/urls.py Outdated Show resolved Hide resolved
Copy link
Contributor

@thclark thclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

Copy link
Contributor

@thclark thclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion on the is_default column plus a couple of notes

docs/source/service_revisions.rst Outdated Show resolved Hide resolved
docs/source/service_revisions.rst Outdated Show resolved Hide resolved
docs/source/service_revisions.rst Outdated Show resolved Hide resolved
docs/source/service_revisions.rst Outdated Show resolved Hide resolved
docs/source/service_revisions.rst Outdated Show resolved Hide resolved
docs/source/service_revisions.rst Outdated Show resolved Hide resolved
@cortadocodes cortadocodes merged commit 86cb902 into main Jul 5, 2023
4 checks passed
@cortadocodes cortadocodes deleted the feature/add-service-registry-endpoints branch July 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Service Registry Endpoints
3 participants