Use correct pluralized words to fix Jekyll Hooks. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pre_render so that it has time to load the front matter.
ryanoglesby08
changed the title
|
This will require Jekyll 3.0, I believe. |
|
Ahhh, hmmmmm. So would you prefer to do a Jekyll version check before registering the hooks, splitting the code paths for v2.x.x and v3.x.x? Or changing the runtime dependency of this plugin to >= Jekyll 3? The latter would probably cause a major version bump too I suppose. |
|
Jekyll 2 has been retired, so I'd personally rather see this move forward
as Jekyll 3 only. That said, I'm not sure what @imathis has in mind for
compatibility. :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct pluralized words in Jekyll Hooks. Move 'pages' hook to pre_render so that it has time to load the front matter.
Attempting to move my blog over to Octopress 3.0 and found this plugin to be broken with Jekyll 3.1.6 because the Jekyll Hooks integration was not specified correctly. Singular vs plural in the symbols. https://jekyllrb.com/docs/plugins/#hooks
Clash test was broken when I forked it. Fixed the clash expectation in the process. Seems to be passing now.
Hope you can pull this in soon so I can use this plugin. :)