Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw an error when passing an object payload to verify or sign #235

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

wolfy1339
Copy link
Member

Resolves probot/probot#1974
See octokit/webhooks.js#961 (comment)


Before the change?

  • Silently accepts payload objects when users aren't using TypeScript

After the change?

  • Throws an error whenever an object payload is passsed

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Feb 16, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m gr2m changed the title feat: add warning when passing object payloads feat: throw an error when passing an object payload to verify or sign Feb 17, 2024
@gr2m gr2m merged commit e2bcb2c into main Feb 17, 2024
7 checks passed
@gr2m gr2m deleted the add-object-payload-warning branch February 17, 2024 18:24
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Failing to verify requests
2 participants