Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "default" export in published package.json #542

Merged
merged 3 commits into from Apr 23, 2024

Conversation

KyleBoyer
Copy link
Contributor

@KyleBoyer KyleBoyer commented Apr 23, 2024

Resolves #541


Before the change?

  • No "default" defined in package.json -> exports['.']

After the change?

  • "default" field appended to package.json -> exports['.']

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Related PRs

octokit/plugin-throttling.js#695
octokit/plugin-paginate-graphql.js#195

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Can you please add the documentation as well?
Follow octokit/auth-action.js#405

@KyleBoyer
Copy link
Contributor Author

Can you please add the documentation as well? Follow octokit/auth-action.js#405

Added!

@wolfy1339 wolfy1339 enabled auto-merge (squash) April 23, 2024 20:30
@wolfy1339 wolfy1339 merged commit 4cc1275 into octokit:main Apr 23, 2024
5 checks passed
Copy link

🎉 This PR is included in version 7.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: "default" export missing from package.json
2 participants