Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): bump @octokit/tsconfig major version #504

Merged
merged 3 commits into from Jun 7, 2023
Merged

Conversation

kfcampbell
Copy link
Member

This PR uses auth-token.js#345 as a model to update the major octokit/tsconfig version, revert the breaking engines change (that will take place during the upcoming Node 14/16 deprecation), and adds a test-specific tsconfig.

@kfcampbell kfcampbell requested a review from wolfy1339 June 7, 2023 16:44
@ghost ghost added this to Inbox in JS Jun 7, 2023
@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 7, 2023
@ghost ghost moved this from Inbox to Maintenance in JS Jun 7, 2023
@kfcampbell kfcampbell changed the title fix(build): tsconfig major version and revert breaking engine change fix(build): bump tsconfig major version and revert breaking engine change Jun 7, 2023
package.json Outdated Show resolved Hide resolved
@wolfy1339
Copy link
Member

The PR for Node 14/16 removal was merged here already

Co-authored-by: wolfy1339 <[email protected]>
package.json Outdated Show resolved Hide resolved
@kfcampbell
Copy link
Member Author

Ahh oops, thanks!

@wolfy1339 wolfy1339 changed the title fix(build): bump tsconfig major version and revert breaking engine change fix(build): bump @octokit/tsconfig major version Jun 7, 2023
@wolfy1339 wolfy1339 merged commit e47872b into main Jun 7, 2023
7 checks passed
@wolfy1339 wolfy1339 deleted the bump-tsconfig branch June 7, 2023 22:14
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

2 participants