Fix add_record() lenient check to allow managed sub-zone DS records

[rasturic]

Like NS records, it's valid to have a sub-zone record name as zone being managed.

[ross]

👍 to the change. Needs a bit of testing to go along with it. Looks like the existing tests of NS behavior are

octodns/tests/test_octodns_zone.py

Lines 311 to 337 in fae406a

	# NS for something below the sub is rejected
	zone = Zone('unit.tests.', set(['sub', 'barred']))
	record = Record.new(
	zone,
	'foo.sub',
	{'ttl': 3600, 'type': 'NS', 'values': ['1.2.3.4.', '2.3.4.5.']},
	)
	with self.assertRaises(SubzoneRecordException) as ctx:
	zone.add_record(record)
	self.assertTrue('under a managed sub-zone', str(ctx.exception))
	# Can add it w/lenient
	zone.add_record(record, lenient=True)
	self.assertEqual(set([record]), zone.records)
	# A for something below the sub is rejected
	zone = Zone('unit.tests.', set(['sub', 'barred']))
	record = Record.new(
	zone,
	'foo.bar.sub',
	{'ttl': 3600, 'type': 'A', 'values': ['1.2.3.4', '2.3.4.5']},
	)
	with self.assertRaises(SubzoneRecordException) as ctx:
	zone.add_record(record)
	self.assertTrue('under a managed sub-zone', str(ctx.exception))
	# Can add it w/lenient
	zone.add_record(record, lenient=True)
	self.assertEqual(set([record]), zone.records)

[rasturic]

👍 to the change. Needs a bit of testing to go along with it. Looks like the existing tests of NS behavior are

octodns/tests/test_octodns_zone.py

Lines 311 to 337 in fae406a

	# NS for something below the sub is rejected
	zone = Zone('unit.tests.', set(['sub', 'barred']))
	record = Record.new(
	zone,
	'foo.sub',
	{'ttl': 3600, 'type': 'NS', 'values': ['1.2.3.4.', '2.3.4.5.']},
	)
	with self.assertRaises(SubzoneRecordException) as ctx:
	zone.add_record(record)
	self.assertTrue('under a managed sub-zone', str(ctx.exception))
	# Can add it w/lenient
	zone.add_record(record, lenient=True)
	self.assertEqual(set([record]), zone.records)
	# A for something below the sub is rejected
	zone = Zone('unit.tests.', set(['sub', 'barred']))
	record = Record.new(
	zone,
	'foo.bar.sub',
	{'ttl': 3600, 'type': 'A', 'values': ['1.2.3.4', '2.3.4.5']},
	)
	with self.assertRaises(SubzoneRecordException) as ctx:
	zone.add_record(record)
	self.assertTrue('under a managed sub-zone', str(ctx.exception))
	# Can add it w/lenient
	zone.add_record(record, lenient=True)
	self.assertEqual(set([record]), zone.records)

I was wondering about that. Hopefully the ones I just pushed up are good.

[ross]

Testing looks good. Thanks!