Open raw sockets when adding hosts, not when doing the pinging #35
Conversation
This allows this to run as non-root again, without this, oping will have dropped privileges before trying to ping, which then fails to open the necessary raw sockets. Fixes: octo#34
|
I've uploaded a version to Debian that includes this fix. |
|
Could this be related to #43 - I'm using Ubuntu version which most likely includes the same fix. |
|
Hi, this patch (or something along that lines) is necessary for oping/noping to work correctly on FreeBSD for non-root users (running suid root). "master as is" will drop privs too early, resulting in a cascade of ping_send failed: Operation not permitted even when installed mode 4711 (suid root). @octo can you please merge this, or something similar? I am willing test variants on FreeBSD. We use noping a lot, but we want the multiping patch, so we need "master + privilege dropping fix"... thanks |
Add patch from upstream merge quest [1] to fix suid root feature. [1] octo/liboping#35 Signed-off-by: Peter Seiderer <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
Hi @tfheen , I am using liboping library for sending ping request in containerized environment where it fails for non-root user. I could see the Fix but it is not yet merged. any idea when will it be released? Thanks! |
|
@NallasivanK , I'm not the liboping maintainer, and haven't seen any activity from the maintainer in this bug report, so no. I see the last commit to the repository was five years ago, so I'm not sure about the maintenance status of liboping. |
Thanks @tfheen .. Hi @octo , I am in need of this fix. Is there any plan for next release with this fix. Thanks |
This allows this to run as non-root again, without this, oping will
have dropped privileges before trying to ping, which then fails to
open the necessary raw sockets.
Fixes: #34