Backends: Vulkan: AddTexture alternative public API taking a descriptor pool #7249
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional VkDescriptorPool to the AddTexture calls. I've had many issues with my pool running out of descriptor sets, and calling VkResetDescriptorPool invalidates all of ImGui in a weird way, mapping my images (image descriptors) onto the fonts etc. This solution simply adds an optional descriptor pool which you can reset independently of ImGui in a way that's "better" (please discuss) for Vulkan applications where you typically already have that kind of management implemented.
ocornut
changed the title
|
@ocornut Any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional VkDescriptorPool to the AddTexture calls. I've had many issues with my pool running out of descriptor sets, and calling VkResetDescriptorPool invalidates all of ImGui in a weird way, mapping my images (image descriptors) onto the fonts etc.
This solution simply adds an optional descriptor pool which you can reset independently of ImGui in a way that's "better" (please discuss) for Vulkan applications where you typically already have that kind of management implemented.
The old API is implemented by means of the new API.