Add checks for ddo chain id and did. #1868
Merged
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariacarmina
requested review from
mihaisc,
alexcos20,
bogdanfazakas,
paulo-ocean and
jamiehewitt15
as code owners
|
Can you check what the issue with the integration test is? |
It seems that the modifications work fine :)) so the tests failed as expected, I'll modify the chain id from the samples DDOs to match barge test chain id. |
paulo-ocean
reviewed
Oct 31, 2024
mariacarmina
force-pushed
the
add-checks-for-ddo
branch
from
0b85ffb
to
3a36e92
Compare
github-actions
bot
force-pushed
the
add-checks-for-ddo
branch
from
ad71c74
to
5e1c70f
Compare
github-actions
bot
force-pushed
the
add-checks-for-ddo
branch
from
8ac446d
to
7424273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR: