Skip to content

Commit

Permalink
Merge pull request #11 from oceanprotocol/feature/node-security
Browse files Browse the repository at this point in the history
add eslint-plugin-security
  • Loading branch information
kremalicious authored Aug 24, 2018
2 parents bc9f70a + 21e2136 commit b0f308b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Don't be like that cat.
For every project containing JavaScript, ESLint should be set up with this config. For this you need to install all required `peerDependencies` on your own. In one handy command:

```bash
npm install --save-dev eslint eslint-config-oceanprotocol eslint-config-standard eslint-plugin-standard eslint-plugin-promise eslint-plugin-import eslint-plugin-node
npm install --save-dev eslint eslint-config-oceanprotocol eslint-config-standard eslint-plugin-standard eslint-plugin-promise eslint-plugin-import eslint-plugin-node eslint-plugin-security
```

Then, create a new file `.eslintrc` in the root of your project and fill with:
Expand All @@ -49,7 +49,7 @@ Then, create a new file `.eslintrc` in the root of your project and fill with:
When using within a React project use this to get set up:

```bash
npm install --save-dev eslint eslint-config-oceanprotocol eslint-config-standard eslint-config-standard-react eslint-plugin-standard eslint-plugin-promise eslint-plugin-import eslint-plugin-node eslint-plugin-react
npm install --save-dev eslint eslint-config-oceanprotocol eslint-config-standard eslint-config-standard-react eslint-plugin-standard eslint-plugin-promise eslint-plugin-import eslint-plugin-node eslint-plugin-security eslint-plugin-react
```

And in your `.eslintrc`:
Expand Down
3 changes: 3 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
module.exports = {
extends: [
'eslint:recommended',
'plugin:security/recommended',
'standard'
],

'plugins': ['security'],

rules: {
'indent': [2, 4, { 'SwitchCase': 1, 'VariableDeclarator': 1 }],
'space-before-function-paren': [2, { 'anonymous': 'never', 'named': 'never' }],
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-promise": "^4.0.0",
"eslint-plugin-react": "^7.10.0",
"eslint-plugin-security": "^1.4.0",
"eslint-plugin-standard": "^3.1.0",
"release-it": "^7.4.7"
},
Expand All @@ -36,6 +37,7 @@
"eslint-config-standard-react": "^6.0.0",
"eslint-plugin-import": "^2.13.0",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-security": "^1.4.0",
"eslint-plugin-promise": "^4.0.0",
"eslint-plugin-standard": "^3.1.0"
},
Expand Down
2 changes: 2 additions & 0 deletions react.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ module.exports = {
extends: [
'eslint:recommended',
'plugin:react/recommended',
'plugin:security/recommended',
'standard',
'standard-react'
],
'plugins': ['security'],

rules: Object.assign({}, base.rules, reactRules)
}

0 comments on commit b0f308b

Please sign in to comment.