Skip to content

fix(db-browser): the precision of a MySQL YEAR type can be 0 #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev/4.3.x
Choose a base branch
from
Open

fix(db-browser): the precision of a MySQL YEAR type can be 0 #4164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...in/java/com/oceanbase/tools/dbbrowser/schema/mysql/MySQLNoLessThan5700SchemaAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public class MySQLNoLessThan5700SchemaAccessor implements DBSchemaAccessor {
SPECIAL_TYPE_NAMES.add("bigint");
SPECIAL_TYPE_NAMES.add("float");
SPECIAL_TYPE_NAMES.add("double");
SPECIAL_TYPE_NAMES.add("year");
}

public MySQLNoLessThan5700SchemaAccessor(@NonNull JdbcOperations jdbcOperations) {
Expand Down Expand Up @@ -605,6 +606,13 @@ protected RowMapper<DBTableColumn> listTableRowMapper() {

protected void fillPrecisionAndScale(DBTableColumn column) {
String typeName = column.getTypeName();
/*
In higher mysql version(from 5.7.5),Year's precision is set to default 4 in ddl sql and table construction compare,
especially when columntype=yaer(2),the year's precision will be set 2
*/
if ("year".equalsIgnoreCase(typeName)) {
column.setPrecision(4L);
}
if (SPECIAL_TYPE_NAMES.contains(Objects.isNull(typeName) ? null : typeName.toLowerCase())) {
String precisionAndScale = DBSchemaAccessorUtil.parsePrecisionAndScale(column.getFullTypeName());
if (StringUtils.isBlank(precisionAndScale)) {
Expand Down
2 changes: 1 addition & 1 deletion ...test/java/com/oceanbase/tools/dbbrowser/schema/MySQLNoLessThan5700SchemaAccessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ private static void initVerifyDataTypes() {
DataType.of("col24", "time", 0, 0L, 0, null),
DataType.of("col25", "date", 0, null, 0, null),
DataType.of("col26", "datetime", 0, 0L, 0, null),
DataType.of("col27", "year", 0, 0L, 0, null)));
DataType.of("col27", "year", 4, 4L, 0, null)));
}

@Data
Expand Down
Loading