fix(cram): sanitize timed-out partial output#15354
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-ttnyosyrztmn
branch
from
3d33aa1 to
128ed4e
Compare
Record the build path prefix map when each cram command starts, so output from a command killed by a timeout can still be path-rewritten. Keep started-but-incomplete commands as unreachable when the cram process did not time out, since shell errors such as syntax errors and explicit exits should not be reported as timeouts. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-ttnyosyrztmn
branch
from
128ed4e to
7aff998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record the build path prefix map when each cram command starts, so output from a command killed by a timeout can still be path-rewritten.
Keep started-but-incomplete commands as unreachable when the cram process did not time out, since shell errors such as syntax errors and explicit exits should not be reported as timeouts.