show env: accept absolute workspace paths#15296
Open
pushkarscripts wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi @pushkarscripts, thanks for the PR. I opened #15114 a little bit ago, could you rebase on top of that so we can see the test update? |
pushkarscripts
force-pushed
the
ps/fix-show-env-absolute-paths
branch
2 times, most recently
from
c00a9d8 to
93cf43c
Compare
Author
Done! I've rebased it. |
Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
pushkarscripts
force-pushed
the
ps/fix-show-env-absolute-paths
branch
from
93cf43c to
63a732e
Compare
Alizter
requested changes
Jun 27, 2026
Alizter
left a comment
Alizter
left a comment
Collaborator
There was a problem hiding this comment.
Also needs a changes entry
| (-short-paths -keep-locs -warn-error +a -w +27)) | ||
|
|
||
| CR-someday Alizter: the same call from a subdirectory should also resolve. | ||
| (--root is required because INSIDE_DUNE disables workspace auto-detection.) |
Collaborator
There was a problem hiding this comment.
This prose needs to be updated now that the test is exhibiting the correct behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15104.
dune describe envcurrently rejects absolute paths even when they point inside the workspace because the argument is classified asExternalimmediately afterPath.of_string.This change localizes workspace-relative absolute paths using
Path.Expert.try_localize_externalbefore callingUtil.check_path.Verified behavior:
dune describe env .continues to workdune describe env "$PWD"now worksdune describe env "$PWD/subdir"now worksdune describe env /tmpcontinues to reportEnvironment is not defined for external pathsThe issue can be reproduced on current
mainand is resolved by this change.