Fix sites plugin test#15224
Open
paurkedal wants to merge 2 commits into
Open
Conversation
Alizter
added
the
dune-site-plugin
paurkedal
force-pushed
the
fix-sites-plugin-test
branch
from
e7856e0 to
39373c0
Compare
This shows that plugin1 is not correctly installed when attempting to load it. Signed-off-by: Petter A. Urkedal <urkedal@nbi.dk>
Extracting a separate tar-file for the plugin subdirectory seems to fix the installation. Signed-off-by: Petter A. Urkedal <urkedal@nbi.dk>
paurkedal
force-pushed
the
fix-sites-plugin-test
branch
from
39373c0 to
19fad0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #11998 the test as it currently stands does not test loading of plugins since there seems to be a bug in the package installation for the plugin. To illustrate this, I made two commits, one which exposes the installation issue and another which fixes the issue. Or is the fix really a workaround for an unrelated issue with dune pkg lock?
There may be another thing blocking the loading of the plugin. Notice that the plugins directory for app ends up under the plugin1 installation, while I presume it's meant to mix into the app installation. Is that supported by the plugin system? In any case, that's not the (only) real issue:
I also tried to check
Sites.Plugins.Plugins.list (), which always returns the empty list with the variations I've tried for this test, contrary to my observation for an opam-installed binary, as mentioned in paurkedal/ocaml-caqti#140.