pkg: print portable solutions grouped by platform #12620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Related to #11868 |
Collaborator
Author
|
Here's an example of the message printed after solving: |
rgrinberg
approved these changes
Oct 25, 2025
| @@ -29,6 +29,7 @@ val extend : t -> t -> t | |||
| val with_defaults : t | |||
|
|
|||
| val pp : t -> 'a Pp.t | |||
Collaborator
Author
There was a problem hiding this comment.
Yep, it's still used in places where only a single Solver_env.t is printed.
gridbugs
force-pushed
the
portable-lockdirs-print-packages-by-platform
branch
3 times, most recently
from
b41334d to
25fbabd
Compare
The message that prints after solving lists each package in the solution. When a solution is portable, it's possible (though hopefully rare) that the version of a package included in a solution will be different depending on the platform. This led to multiple versions of the same package appearing in the message for non-obvious reasons, which some found confusing. This commit changes the message when portable lockdirs are enabled, such that the packages common to all platforms are printed together, and each set of platform-specific dependencies is printetd separately from the common dependencies. Signed-off-by: Stephen Sherratt <[email protected]>
gridbugs
force-pushed
the
portable-lockdirs-print-packages-by-platform
branch
from
25fbabd to
0ff4e15
Compare
MixiMaxiMouse
pushed a commit
to MixiMaxiMouse/dune
that referenced
this pull request
Nov 3, 2025
The message that prints after solving lists each package in the solution. When a solution is portable, it's possible (though hopefully rare) that the version of a package included in a solution will be different depending on the platform. This led to multiple versions of the same package appearing in the message for non-obvious reasons, which some found confusing. This commit changes the message when portable lockdirs are enabled, such that the packages common to all platforms are printed together, and each set of platform-specific dependencies is printetd separately from the common dependencies. Signed-off-by: Stephen Sherratt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message that prints after solving lists each package in the solution. When a solution is portable, it's possible (though hopefully rare) that the version of a package included in a solution will be different depending on the platform. This led to multiple versions of the same package appearing in the message for non-obvious reasons, which some found confusing.
This commit changes the message when portable lockdirs are enabled, such that the packages common to all platforms are printed together, and each set of platform-specific dependencies is printetd separately from the common dependencies.