Skip to content

STM Weak test re-revision #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

STM Weak test re-revision #558

wants to merge 13 commits into from

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jun 11, 2025

I recently had a fresh look at the weak array and weak hash set STM tests, and discovered a couple of things.
This PR is the outcome.

The weak array and weak hash set test originated in #214.
They've since been tweaked, e.g., in #365 which among other things switched to int64 data for the weak hash sets test,
arguing that this was faster to shrink. As we no longer shrink the data this argument no longer holds.
Furthermore, the tests triggered crashes in the past with string data in #283, which was caused by a combination of race conditions and variable length memory records. This speaks for reverting and using strings for both tests. I've confirmed that both parallel tests can trigger segfaults on an older version (OCaml 5.0.0~alpha1) with these changes.

The PR also

  • revises the post-conditions slightly,
  • adjusts the frequencies slightly to skew them towards making additions, and
  • cleans up the protect calls with thunks, rather than the current missing-last-argument-closure

@jmid
Copy link
Collaborator Author

jmid commented Jun 12, 2025

CI summary for 7ce003b: all 13 trunk workflows (except trunk debug) failed due to #559

  • 32bit trunk
  • Bytecode trunk
  • Cygwin trunk
  • FP trunk
  • Linux trunk
  • Linux-ARM64 trunk
  • macOS-ARM64 trunk
  • macOS-intel trunk
  • MinGW bytecode trunk
  • MinGW trunk
  • MSVC bytecode trunk
  • MSVC trunk
  • musl trunk

Out of 50 workflows, 13 failed with a genuine issue

@jmid jmid force-pushed the weak-re-revision branch from 7ce003b to d1ae3f9 Compare June 19, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant