Add more information to ocamlobjinfo output
#3622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user writes
module Foo = Bar(Param)(Arg) [@jane.non_erasable.instances]
under `-no-alias-deps`, then we add `Bar` to the list of interface imports (with
no CRC), but not `Param` or `Arg`. This doesn't really reflect what's going on:
resolving that alias will require loading all three of `bar.cmi`, `param.cmi`,
and `arg.cmi`. As a result, `ocamlobjinfo` is giving incomplete information
about dependencies.
We've been printing the `Import_info.name`s of implementation imports, but this leaves off the arguments of any instances that are imported (often leading to multiple rows with the same name but different CRCs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended to review commit-by-commit.
There are a couple of useful bits of data missing from
ocamlobjinfooutput, which may be of interest if one's build rules are using it to compute dependency information:-no-alias-depson), only the head appears in the interface imports of the module, even though resolving the alias will require loading all parts of the instance name.This PR addresses both issues.