Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor makefile fixes #3620

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Minor makefile fixes #3620

merged 2 commits into from
Feb 25, 2025

Conversation

dkalinichenko-js
Copy link
Contributor

@dkalinichenko-js dkalinichenko-js commented Feb 25, 2025

Stop trying to copy stdlib/$${universe}/* instead of stdlib/stdlib_$${universe}/*, the rename has happened a while ago.

For test promotion to succeed, contents of _runtest/testsuite must be hardlinks to original files. Use rsync instead of $(cpl) to ensure the linking happens on both Linux and MacOS.

Tested manually on both Linux and MacOS.

* `value_or_null` arguments to `list` and `option`

* Tests

* Accept tests

---------

Co-authored-by: Diana Kalinichenko <[email protected]>
@goldfirere
Copy link
Collaborator

This now contains #3623 -- looks intentional, but perhaps confusing.

@dkalinichenko-js dkalinichenko-js merged commit 62a931d into main Feb 25, 2025
23 checks passed
@dkalinichenko-js dkalinichenko-js deleted the dkalinichenko/makefile-fixes branch February 25, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants