Fix cppo -version and improve make release
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #92.
Change [make clean] to use [git clean -fX]. Change [make publish] into [make release VERSION=X.Y.Z] and improve it to perform a number of checks before running [opam publish].
fpottier
requested review from
liyishuai,
mjambon and
pmetzger
as code owners
pmetzger
reviewed
Sep 5, 2024
liyishuai
approved these changes
Sep 6, 2024
First test if this is the master branch and everything is clean; then compile.
|
Looks good to me! (Feel free to merge when you feel comfortable with it.) |
|
Thanks, I have merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #92 and proposes an improved command
make release VERSION=X.Y.Zwhich creates and publishes a new release.