Skip to content

Add RFC: Reverse Domain Name Notation naming convention #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Xaymar
Copy link

@Xaymar Xaymar commented Jun 8, 2021

Description

Adopt the Reverse Domain Name notation naming convention to reduce potential collisions.

Motivation and Context

Naming for additions has no guarantee that future additions to OBS or plugins do not eventually collide and corrupt setups. A unified naming convention that by design already prevents this should be adopted and enforced.

Link to RFC

@Xaymar
Copy link
Author

Xaymar commented Jun 8, 2021

Partial change extracted from #34 and #35 in order to reduce massive RFCs into smaller ones.

@WizardCM
Copy link
Member

WizardCM commented Jun 8, 2021

I personally like this sound of this change, but I feel a migration path / backwards compatibility would need to be fleshed out extensively. For example, somehow check what version of libobs a plugin is built against - and if it's old enough, ignore the notation rule but warn the user that the plugin may break/conflict.

@Xaymar
Copy link
Author

Xaymar commented Jun 8, 2021

@WizardCM: I feel a migration path / backwards compatibility would need to be fleshed out extensively.

I have added a possible migration path that should be compatible with old and new plugins.

For example, somehow check what version of libobs a plugin is built against - and if it's old enough, ignore the notation rule but warn the user that the plugin may break/conflict.

Added, though it is considered an optional component.

@Xaymar
Copy link
Author

Xaymar commented Aug 5, 2021

Closing as requested.

@Xaymar Xaymar closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants