Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update volume meter appearance #10625

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Warchamp7
Copy link
Member

Description

Adjusts the layout and appearance of the audio mixer volume controls. Removes minor ticks, dims the decibel indication text, widens the meters for lower channel counts, and adds 10db ticks to the slider.

Before:
image

image

After:
image

image

Depends on #10602, or at least will prefer to merge that first so that this can be rebased against it.

Motivation and Context

Better use of space, less visual noise.

How Has This Been Tested?

Messed with audio sources and the audio sliders

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 added the UI/UX Anything to do with changes or additions to UI/UX elements. label Apr 30, 2024
@WizardCM WizardCM added Enhancement Improvement to existing functionality Request for Comments More feedback & discussion is requested labels Apr 30, 2024
@notr1ch
Copy link
Member

notr1ch commented May 1, 2024

I'm not a huge fan of the larger bars and handles, it feels a bit cheap and Fisher Pricey but maybe I need to get used it. The new UI seems a bit cramped with everything so close together. I feel like the icons for properties and mute should also be the same size if they are going next to each other.

@tt2468
Copy link
Member

tt2468 commented May 1, 2024

After hearing some responses from broadcast folks, I would suggest adding minor ticks back between -25dBFS and -5dBFS.

@Warchamp7
Copy link
Member Author

I'm not a huge fan of the larger bars and handles, it feels a bit cheap and Fisher Pricey but maybe I need to get used it. The new UI seems a bit cramped with everything so close together. I feel like the icons for properties and mute should also be the same size if they are going next to each other.

I think you'd be hard pressed to find another audio application that has the meters as thin as we used to have them.

The icons are intended to be the same size. There is an open PR to address that inconsistency

After hearing some responses from broadcast folks, I would suggest adding minor ticks back between -25dBFS and -5dBFS.

I'll try to play around with this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should not be there, since it got removed a while ago.

@lextra2
Copy link

lextra2 commented May 2, 2024

dB font should have a higher contrast
maybe give it the same colour as the volume slider? since they're connected?

@Lain-B
Copy link
Collaborator

Lain-B commented May 5, 2024

I'll have to defer to everyone else for discussion about all the details but I feel like colorblind people will definitely appreciate this PR. I also like how it adds the volume level lines to the slider.

@klemun
Copy link

klemun commented May 5, 2024

Thoughts on aligning the 3 vertical dots on these red vertical lines instead? Otherwise, looks good!
Screenshot 2024-05-05 120225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality Request for Comments More feedback & discussion is requested UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants