obs-outputs: Add eRTMP multitrack audio support #10618
Draft
+222
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palana
force-pushed
the
ruwen/upstream-multitrack-audio
branch
2 times, most recently
from
549d4c1
to
f1b0094
Compare
|
#10500 has been merged, so this can be rebased and undrafted. |
RytoEX
requested changes
May 3, 2024
RytoEX
reviewed
May 5, 2024
palana
force-pushed
the
ruwen/upstream-multitrack-audio
branch
2 times, most recently
from
28e0352
to
b55ac21
Compare
RytoEX
force-pushed
the
ruwen/upstream-multitrack-audio
branch
from
b55ac21
to
2587c32
Compare
|
For what it's worth, I tested this and it worked as expected/configured. |
RytoEX
approved these changes
May 9, 2024
|
Holding this due to a confirmed issue regarding audio/video desync that is unique to this implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to multitrack video, eRTMP also includes support for multitrack audio, thus making things like VOD track available in the spec, rather than relying on FLV byte arrays
Motivation and Context
VOD track currently uses FLV byte arrays to carry the additional audio track, where byte arrays are part of the spec, but using them for audio isn't. With the updated eRTMP multitrack audio support general overhead is lower and also the transport format is part of an open specification.
How Has This Been Tested?
eRTMP multitrack audio is being tested internally at Twitch
Types of changes
Checklist: