Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Refactor system tray #10614

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Apr 28, 2024

Description

This moves the system tray to its own file.

Motivation and Context

Instead of being strewn all over OBSBasic, the system tray code is now consolidated into its own file, making it easier to maintain.

How Has This Been Tested?

Used system tray to perform actions in OBS.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This moves the system tray to its own file.
Copy link
Collaborator

@tytan652 tytan652 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend API should not be consumed in the UI, it should be done alike to #7278.

@cg2121
Copy link
Contributor Author

cg2121 commented Apr 28, 2024

#7278 will need to be merged first in order to use signals instead of the frontend api. So until that happens, I'll mark this as draft for now.

@cg2121 cg2121 marked this pull request as draft April 28, 2024 18:00
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants